fix: match gelu with paper implementation #1421
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avik-pal
force-pushed
the
ap/gelu_tanh_overload
branch
from
61ba67f to
1b4b912
Compare
wsmoses
approved these changes
Jun 26, 2025
wsmoses
reviewed
Jun 26, 2025
avik-pal
force-pushed
the
ap/gelu_tanh_overload
branch
from
9b9d53d to
c1438d6
Compare
|
avik-pal
force-pushed
the
ap/gelu_tanh_overload
branch
from
c1438d6 to
3a3d991
Compare
avik-pal
force-pushed
the
ap/gelu_tanh_overload
branch
from
3a3d991 to
a839436
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing tests already check the numerics